Be clearer in definition of Inf and avoid relying on Modelica.Constants. #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
reviewed
Nov 13, 2024
chapters/classes.tex
Outdated
| @@ -1500,6 +1500,12 @@ \subsection{Real Type}\label{real-type} | |||
| \index{unbounded@\robustinline{unbounded}!attribute of \robustinline{Real}}% | |||
| \index{stateSelect@\robustinline{stateSelect}!attribute of \robustinline{Real}} | |||
|
|
|||
| The default \lstinline!min!- and \lstinline!max!-attributes do not constrain the value. | |||
There was a problem hiding this comment.
What are default attributes? It can't be default values since there are no values assigned.
There was a problem hiding this comment.
I have tried to rewrite that, but still without introducing a special +Inf symbol.
If that fails we can just skip the last two commits.
|
The non-normative comment:
is related to C++ having such a mismatched pair:
but I think it is a general naming issue deserving of a comment, and not only a C/C++-problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I meant with inlining the definition of Modelica.Constants.inf.
For comparison:
In C:
In C++ (C++11 and later); https://en.cppreference.com/w/cpp/types/numeric_limits